Open
Conversation
Reviewer's guide (collapsed on small PRs)Reviewer's GuideThis PR bumps several runtime and dev dependencies in package.json (and the corresponding pnpm-lock.yaml) to newer minor/patch versions, primarily for bug fixes, security updates, and tooling improvements, without any code changes. File-Level Changes
Tips and commandsInteracting with Sourcery
Customizing Your ExperienceAccess your dashboard to:
Getting Help
|
![sourcery-ai[bot]](https://avatars.githubusercontent.com/in/48477?s=60&v=4){kind=small}
There was a problem hiding this comment.
Hey - I've found 2 issues, and left some high level feedback:
- The
jest-environment-jsdommajor version (30.x) is ahead ofjest(29.x), which can cause runtime/test issues; consider aligning these to the same major or upgrading the Jest stack consistently. - Upgrading
typescriptto 5.9.x while keeping older tooling likets-jest@27and@typescript-eslint/eslint-plugin@5.6.0may introduce type-checking or build issues; it’s worth verifying their compatibility matrix and bumping those tools accordingly in this PR.
Prompt for AI Agents
Please address the comments from this code review:
## Overall Comments
- The `jest-environment-jsdom` major version (30.x) is ahead of `jest` (29.x), which can cause runtime/test issues; consider aligning these to the same major or upgrading the Jest stack consistently.
- Upgrading `typescript` to 5.9.x while keeping older tooling like `ts-jest@27` and `@typescript-eslint/eslint-plugin@5.6.0` may introduce type-checking or build issues; it’s worth verifying their compatibility matrix and bumping those tools accordingly in this PR.
## Individual Comments
### Comment 1
<location> `package.json:57` </location>
<code_context>
"eslint-plugin-react-hooks": "4.3.0",
"jest": "^29.7.0",
- "jest-environment-jsdom": "^30.0.5",
+ "jest-environment-jsdom": "^30.2.0",
"prettier": "^2.8.8",
"react-resize-observer": "^1.1.1",
</code_context>
<issue_to_address>
**issue (bug_risk):** Align `jest-environment-jsdom` major version with the Jest version to avoid runtime incompatibilities.
This project still uses Jest `^29.7.0`, but `jest-environment-jsdom` is now `^30.2.0`. Jest 30 introduced breaking changes and environment packages are generally major-version coupled, so this mismatch can cause subtle test failures. Please either upgrade Jest to 30 as well or keep `jest-environment-jsdom` at a 29.x version to keep majors aligned.
</issue_to_address>
### Comment 2
<location> `package.json:65-66` </location>
<code_context>
"ts-jest": "^27.1.5",
- "typescript": "^5.8.3",
- "vite": "^6.3.6"
+ "typescript": "^5.9.3",
+ "vite": "^6.4.1"
}
}
</code_context>
<issue_to_address>
**issue (bug_risk):** Check `ts-jest` compatibility with the newer TypeScript version.
`ts-jest` is still at `^27.1.5` while `typescript` is now `^5.9.3`. That `ts-jest` version targets older Jest/TS versions and may not support TS 5.9, causing transform or type-checking failures in tests. Please confirm the supported TypeScript range for this `ts-jest` version and either bump `ts-jest` or align the TypeScript version accordingly.
</issue_to_address>Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.
|
Build for commit c8c0ca5 deployed to: https://pipedrive-pr-102.ci.next.deskprodemo.com URLs: |
There was a problem hiding this comment.
Pull request overview
This PR updates multiple dependencies to their latest minor and patch versions to incorporate recent features, bug fixes, and security patches. The updates span both runtime dependencies and development tools, ensuring the project remains current with third-party library improvements.
Key changes:
- Core dependencies upgraded including UI libraries, form handling, routing, and error monitoring tools
- Development dependencies updated for improved type support and testing capabilities
- All updates are non-breaking minor or patch version bumps
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pull request updates several dependencies in the
package.jsonfile to their latest minor or patch versions. These updates are primarily focused on keeping the project up-to-date with the latest features, bug fixes, and security patches from third-party libraries.Dependency updates:
@deskpro/deskpro-ui,@fortawesome/react-fontawesome,@sentry/react,@sentry/vite-plugin,javascript-time-ago,react-hook-form,react-router-dom,react-time-ago, andsimplebarto their latest versions.@types/reactto a newer version for improved type support.jest-environment-jsdom,styled-components,typescript, andviteto ensure compatibility and access to the latest features and fixes.Summary by Sourcery
Update frontend dependencies and development tooling to newer minor and patch versions for maintenance and compatibility.
Enhancements:
Build: